vorburger commented on pull request #1449: URL: https://github.com/apache/fineract/pull/1449#issuecomment-713470796
> is there a reason why you didn't use the "usual" DataValidatorBuilder/BaseDataValidator pattern for this check? Good point. I can't find `BaseDataValidator` (:question:), but the `DataValidatorBuilder` seems to be more used in `.services.` and `.command.`.. I can't find a single instance of it in an `.api.` - but I guess there is no reason why not to? I'll leave this PR as is, and will raise a separate alternative one, for comparison. Who knows, I may even use this as the opportunity to write DOC - imagine that, an open source project with real technical framework documentation!! :smile: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
