vorburger commented on a change in pull request #1465:
URL: https://github.com/apache/fineract/pull/1465#discussion_r510105721
##########
File path: config/checkstyle/suppressions.xml
##########
@@ -27,4 +27,6 @@
<suppressions>
<suppress files="[/\\]build[/\\]generated[/\\]" checks=".*"/>
+ <!-- TODO: fix integration test formatting -->
+ <suppress files="[/\\]integration-tests[/\\]src[/\\]test[/\\]main[/\\]"
checks=".*"/>
Review comment:
I'm guessing we currently haven't covered integration-tests? We should
perhaps try to fix that, first? Or leave as is?
##########
File path: build.gradle
##########
@@ -416,9 +408,14 @@ configure(project.fineractJavaProjects) {
// Configuration for the spotless plugin
// https://github.com/diffplug/spotless/tree/main/plugin-gradle
+ dependencies {
+ spotbugsPlugins 'jp.skypencil.findbugs.slf4j:bug-pattern:1.5.0@jar'
+ spotbugs 'com.github.spotbugs:spotbugs:4.1.4'
+ }
+
spotless {
java {
- targetExclude '**/build/**', '**/bin/**', '**/out/**'
+ targetExclude '**/build/**', '**/bin/**', '**/out/**',
'**/integration-tests/**'
Review comment:
why exclude integration-tests from Spotless now? Or are we already not
covering them? Then we should separately fix that, first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
