vorburger commented on a change in pull request #1444:
URL: https://github.com/apache/fineract/pull/1444#discussion_r512457801
##########
File path:
fineract-provider/src/test/java/org/apache/fineract/common/RestAssuredFixture.java
##########
@@ -34,14 +34,12 @@
private final int httpPort;
- private ResponseSpecification responseSpec;
- private RequestSpecification requestSpec;
+ private final ResponseSpecification responseSpec;
+ private final RequestSpecification requestSpec;
- public RestAssuredFixture(int http) {
-
- this.httpPort = http;
+ public RestAssuredFixture() {
+ this.httpPort = 844;
Review comment:
@awasum well spotted, yes this looks wrong. It's surprising that it
still worked - I think this line can probably be removed. I could do that, but
I think there is a larger question of what direction we want to take re ITs -
I'll comment on the main comment instead of inline here about that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
