vorburger commented on a change in pull request #1404:
URL: https://github.com/apache/fineract/pull/1404#discussion_r526069895



##########
File path: README.md
##########
@@ -59,7 +59,7 @@ The tenants database connection details are configured [via 
environment variable
 Instructions to build a WAR file
 ============
 1. Clone the repository or download and extract the archive file to your local 
directory.
-2. Run `./gradlew clean bootWar` to build a traditional WAR file which will be 
created at `build/libs` directory.
+2. Run `./gradlew clean war` to build a traditional WAR file which will be 
created at `build/libs` directory.

Review comment:
       @avikganguly01 not sure what you mean, if I do `./gradlew war` at the 
root of the latest `develop` branch of the project, then I do get a 
`fineract-provider/build/libs/fineract-provider.war`. Are you perhaps by 
mistake just looking in `build/libs` instead of `fineract-provider/build/libs`? 
That changed, not because of FINERACT-1203 but as part of FINERACT-1171. Will 
you raise a PR to update the README to clarify this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to