vorburger commented on a change in pull request #1567:
URL: https://github.com/apache/fineract/pull/1567#discussion_r559254394
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/ThitsaWorksCreditBureauIntegrationWritePlatformServiceImpl.java
##########
@@ -434,10 +480,14 @@ public String getCreditBureauConfiguration(Integer
creditBureauId, String config
creditBureauConfigurationValue =
configurationParameterValue.getValue();
if (creditBureauConfigurationValue.isEmpty()) {
-
baseDataValidator.reset().failWithCode("creditBureau.configuration." +
configurationParameterName + ".is.not.available");
- throw new PlatformApiDataValidationException(
- "creditBureau.Configuration." +
configurationParameterName + ".is.not.available",
- "creditBureau.Configuration.is.not.available",
dataValidationErrors);
+ /*
+ *
baseDataValidator.reset().failWithCode("creditBureau.configuration." +
configurationParameterName +
+ * ".is.not.available"); throw new
PlatformApiDataValidationException( "creditBureau.Configuration." +
+ * configurationParameterName + ".is.not.available",
"creditBureau.Configuration.is.not.available",
+ * dataValidationErrors);
+ */
+ throw new
PlatformDataIntegrityException("creditBureau.Configuration." +
configurationParameterName + ".is.not.available",
+ "creditBureau.Configuration." +
configurationParameterName + ".is.not.available");
Review comment:
@rrpawar96 did you mean to change this, or this a left over from a local
test that you did not mean to change? If it should change, perhaps you would
prefer to just remove instead of comment out the bean validation which you
don't seem to want to do here anymore? (But why?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
