vorburger commented on a change in pull request #1583:
URL: https://github.com/apache/fineract/pull/1583#discussion_r563161080
##########
File path: kubernetes/fineractmysql-deployment.yml
##########
@@ -96,11 +96,7 @@ spec:
key: password
livenessProbe:
exec:
- command:
- - mysqladmin
- - ping
- - -h
- - localhost
+ command: ["sh","-c","mysqladmin ping -h localhost -uroot
-p${MYSQL_ROOT_PASSWORD}"]
Review comment:
@BLasan oh wait I am dumb, this `MYSQL_ROOT_PASSWORD` **IS** set by us,
in
https://github.com/apache/fineract/blob/develop/kubernetes/fineractmysql-deployment.yml#L92,
now I get how this works! Then this change makes perfect sense - LGTM and I'm
mergint it now. FYI @xurror
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
