awasum commented on a change in pull request #1597:
URL: https://github.com/apache/fineract/pull/1597#discussion_r570785195
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/GmailBackedPlatformEmailService.java
##########
@@ -61,6 +64,18 @@ public void sendDefinedEmail(EmailDetail emailDetails) {
final String authuser = smtpCredentialsData.getUsername();
final String authpwd = smtpCredentialsData.getPassword();
+ LOG.info("Use name: ", smtpCredentialsData.getUsername());
+ LOG.info("Use Password: ", smtpCredentialsData.getPassword());
Review comment:
Why are you logging password and some critical information ? You can do
this in testing on your Dev environment and then remove these lines as critical
information is being exposed here.
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/GmailBackedPlatformEmailService.java
##########
@@ -61,6 +64,18 @@ public void sendDefinedEmail(EmailDetail emailDetails) {
final String authuser = smtpCredentialsData.getUsername();
final String authpwd = smtpCredentialsData.getPassword();
+ LOG.info("Use name: ", smtpCredentialsData.getUsername());
+ LOG.info("Use Password: ", smtpCredentialsData.getPassword());
Review comment:
You can run Fineract on your local machine. Run the front end and test
your changes with the default gmail service without setting up your own smtp on
your PC. Am I missing something here? advice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
