apurv-1 opened a new pull request #1607:
URL: https://github.com/apache/fineract/pull/1607


   ## Description
   
   Describe the changes made and why they were made.
   
   I was setting up the Project on Windows 10, and it was throwing some "file 
not found error", 
   I searched for the problem and found that It was the issue with Docker on 
Windows,
   
   So, One of the issues with Docker (or any Linux/macOS based system) on 
Windows is the difference in how line endings are handled. Windows ends lines 
in a carriage return and a linefeed \r\n while Linux and macOS only use a 
linefeed \n. This becomes a problem when you try to create a file in Windows 
and run it on a Linux/macOS system, because those systems treat the \r as a 
piece of text rather than a newline.
   
   So, I cloned the repo with flag (--config core.autocrlf=input) and this 
worked.
   
   Ignore if these details are present on the associated [Apache Fineract JIRA 
ticket](https://github.com/apache/fineract/pull/1284).
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [ ] Write the commit message as per 
https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at 
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details 
of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in 
repository" via a branch.  Ask on the developer mailing list for guidance, if 
required.)
   
   FYI our guidelines for code reviews are at 
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to