vorburger commented on a change in pull request #1587:
URL: https://github.com/apache/fineract/pull/1587#discussion_r571704060
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/service/LoanScheduleAssembler.java
##########
@@ -336,7 +336,14 @@ private LoanApplicationTerms
assembleLoanApplicationTermsFrom(final JsonElement
*/
final DaysInMonthType daysInMonthType =
loanProduct.fetchDaysInMonthType();
- final DaysInYearType daysInYearType =
loanProduct.fetchDaysInYearType();
+ DaysInYearType daysInYearType = null;
Review comment:
@davidyaha it looks like you haven't had time to address this feedback.
As it's only minor, I'll not let this hold up merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
