ptuomola commented on a change in pull request #1597:
URL: https://github.com/apache/fineract/pull/1597#discussion_r578933084
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/service/ExternalServicesPropertiesReadPlatformServiceImpl.java
##########
@@ -87,8 +87,6 @@ public SMTPCredentialsData extractData(final ResultSet rs)
throws SQLException,
password = value;
} else if
(ExternalServicesConstants.SMTP_HOST.equalsIgnoreCase(name)) {
host = value;
- } else if
(ExternalServicesConstants.SMTP_PORT.equalsIgnoreCase(name)) {
- port = value;
} else if
(ExternalServicesConstants.SMTP_USE_TLS.equalsIgnoreCase(name)) {
Review comment:
Hmm.. why would we not simply store the right port number in the
database when using Gmail?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
