BLasan commented on a change in pull request #1597:
URL: https://github.com/apache/fineract/pull/1597#discussion_r579119188



##########
File path: fineract-provider/dependencies.gradle
##########
@@ -80,7 +80,8 @@ dependencies {
             'org.webjars:webjars-locator-core',
 
             'com.google.cloud.sql:mysql-socket-factory-connector-j-8:1.2.1',
-            'com.squareup.retrofit2:converter-gson'
+            'com.squareup.retrofit2:converter-gson',
+            'com.sun.activation:jakarta.activation:1.2.2'

Review comment:
       Yuh. Your approach is ok @francisguchie . But instead of excluding that 
path, @ptuomola suggested to an exclusion for this particular dependency. I 
tried by adding it. But didn't work.
   
   ```
       implementation ('com.sun.activation:jakarta.activation:1.2.2') {
           exclude group: 'jakarta.activation', module: 'jakarta.activation-api'
           exclude group: 'javax.activation', module: 'javax.activation-api'
       }
   ```
   Am I missing something in here ? @ptuomola 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to