BLasan commented on pull request #1597: URL: https://github.com/apache/fineract/pull/1597#issuecomment-798560104
> I've lost track here... is this one good to merge? > > @ptuomola would you like to re-review this? Has all of your feedback above been addressed, are you good with this as-is now? > > @francisguchie did you functionally test and independently verify this PR - does it solve [FINERACT-1070](https://issues.apache.org/jira/browse/FINERACT-1070)? (Just answer Yes or No.) > > @BLasan when we merge this we should "squash" your work of currently 8 commits as 1 single "squashed" clean commit (but don't do it now, because the open review comments would get lost). > > PS: See also [FINERACT-1335](https://issues.apache.org/jira/browse/FINERACT-1335) and [FINERACT-1270](https://issues.apache.org/jira/browse/FINERACT-1270), but let's not block this anymore, just separate ideas for new future PRs. Sorry sir, my bad. Will keep this in mind. Thanks :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
