EGOR-IND commented on pull request #125: URL: https://github.com/apache/fineract-cn-mobile/pull/125#issuecomment-798948639
I didn't mean that, there is no problem in creating a PR fast, I'm just saying that issue you raised had a little flaw because if you see that fab is for creating role, i think in future there will be some work done on this therefore the fab is not unnecessary😊. I'm just trying to help after all we are working in team. On Sun, Mar 14, 2021, 23:10 Vatsal ***@***.***> wrote: > @PatelVatsalB21 <https://github.com/PatelVatsalB21> you just created an > issue for this and I commented on that please check that comment. Don't > rush to make a PR first think about your issue my friend sometimes we think > the issue is correct but it doesn't mean it's always correct. I don't mean > to offend you, just want you to be more aware:). > > Ok I got it and i will take care of it :) but simple issues take less time > so i made pr instantly. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/fineract-cn-mobile/pull/125#issuecomment-798947578>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ANQGJHSFH7DDDYKKU7YK5BDTDTYKHANCNFSM4ZFFXQIQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
