josemakara2 edited a comment on pull request #1671:
URL: https://github.com/apache/fineract/pull/1671#issuecomment-803552199
Close button accidentally clicked :)
Thanks @thesmallstar .
It is work in progress - will let you know when I consider the task
complete.
I see my build failing as a result of `format violations` to changed files.
I have configured eclipse `fineratcdevprojectformatter` but checking to fix
format.
UPDATE: format fixed = no `format violations`.
Checked travis server and showing below unrelated fail message to this PR.
```
GlobalConfigurationTest > testGlobalConfigurations() FAILED
java.lang.AssertionError: 1 expectation failed.
Expected status code <200> but was <500>.
at
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method)
> Task :integration-tests:test FAILED
WARNING: The web application [fineract-provider] appears to have started a
thread named [fineract_default_pool housekeeper] but has failed to stop it.
This is very likely to create a memory leak.
WARNING: The web application [fineract-provider] appears to have started a
thread named [SimpleAsyncTaskExecutor-1407] but has failed to stop it. This is
very likely to create a memory leak. Stack trace of thread:
> Task :integration-tests:cargoStopLocal
FAILURE: Build failed with an exception.
```
Will carry on with the changes for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
