thesmallstar commented on a change in pull request #1671:
URL: https://github.com/apache/fineract/pull/1671#discussion_r608245107



##########
File path: 
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/api/RunreportsApiResource.java
##########
@@ -105,6 +109,10 @@ public Response runReport(@PathParam("reportName") 
@Parameter(description = "rep
         // Pass through isSelfServiceUserReport so that 
ReportingProcessService implementations can use it
         queryParams.putSingle(IS_SELF_SERVICE_USER_REPORT_PARAMETER, 
Boolean.toString(isSelfServiceUserReport));
 
+        if (parameterType) {
+            return datatableReportingProcessService.processRequest(reportName, 
queryParams);
+        }
+

Review comment:
       Seems to be related to issue 
https://issues.apache.org/jira/browse/FINERACT-1336. Is this issue related to 
SQL injection? I am good to merge this here..however, if they are not related 
it would be better to have a separate PR for this one? 
   
   cc: @ptuomola @vorburger 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to