thesmallstar commented on a change in pull request #1772:
URL: https://github.com/apache/fineract/pull/1772#discussion_r680517516
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java
##########
@@ -255,11 +256,34 @@ public String adjustLoanTransaction(@PathParam("loanId")
@Parameter(description
@Parameter(hidden = true) final String apiRequestBodyAsJson) {
final CommandWrapperBuilder builder = new
CommandWrapperBuilder().withJson(apiRequestBodyAsJson);
- final CommandWrapper commandRequest =
builder.adjustTransaction(loanId, transactionId).build();
+ CommandProcessingResult result = null;
- final CommandProcessingResult result =
this.commandsSourceWritePlatformService.logCommandSource(commandRequest);
+ final CommandWrapper commandRequest =
builder.adjustTransaction(loanId, transactionId).build();
+ result =
this.commandsSourceWritePlatformService.logCommandSource(commandRequest);
Review comment:
can you please explain this part?
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/exception/LoanChargeWaiveCannotBeReversedException.java
##########
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.portfolio.charge.exception;
+
+import
org.apache.fineract.infrastructure.core.exception.AbstractPlatformDomainRuleException;
+
+public class LoanChargeWaiveCannotBeReversedException extends
AbstractPlatformDomainRuleException {
+
+ /*** enum of reasons of why Loan Charge waive cannot undo **/
+ public enum LoanChargeWaiveCannotUndoReason {
+
+ ALREADY_PAID, ALREADY_WAIVED, LOAN_INACTIVE,
WAIVE_NOT_ALLOWED_FOR_CHARGE, NOT_WAIVED, ALREADY_REVERSED;
+
+ public String errorMessage() {
+ /**
+ * TODO: Recheck the error messages
+ */
Review comment:
who needs to do this?
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java
##########
@@ -255,11 +256,34 @@ public String adjustLoanTransaction(@PathParam("loanId")
@Parameter(description
@Parameter(hidden = true) final String apiRequestBodyAsJson) {
final CommandWrapperBuilder builder = new
CommandWrapperBuilder().withJson(apiRequestBodyAsJson);
- final CommandWrapper commandRequest =
builder.adjustTransaction(loanId, transactionId).build();
+ CommandProcessingResult result = null;
- final CommandProcessingResult result =
this.commandsSourceWritePlatformService.logCommandSource(commandRequest);
+ final CommandWrapper commandRequest =
builder.adjustTransaction(loanId, transactionId).build();
+ result =
this.commandsSourceWritePlatformService.logCommandSource(commandRequest);
return this.toApiJsonSerializer.serialize(result);
}
+ /**
+ * TODO: Add Swagger annotations.
+ *
Review comment:
Is this done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
