ptuomola commented on pull request #1820: URL: https://github.com/apache/fineract/pull/1820#issuecomment-902675162
I think we already have a “stub” for fineract-client test in fineract/fineract-client/src/test/java/org/apache/fineract/client/test - it should be easy to add to this or create more similar tests in the same package. My suggestion would be to: a) for each Swagger API that is fixed, add a test to show that it works b) add running the tests to integration tests in Travis so that the build fails if these tests fail That way we could ensure that a) the fixes are correct and b) the code works not just now but also in the future... > On 20 Aug 2021, at 8:48 PM, Awasum Yannick ***@***.***> wrote: > > > @danishjamal104 <https://github.com/danishjamal104> , I wonder if you have been able to add any tests as @ptuomola <https://github.com/ptuomola> asked in PR: #1828 <https://github.com/apache/fineract/pull/1828> > How difficult is it to add those test to make sure the Swagger Docs are actually correct? see: https://stackoverflow.com/questions/39620552/generate-unit-test-code-from-swagger-api-for-java-rest <https://stackoverflow.com/questions/39620552/generate-unit-test-code-from-swagger-api-for-java-rest> > @ptuomola <https://github.com/ptuomola> I see your point. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub <https://github.com/apache/fineract/pull/1820#issuecomment-902667118>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASJVCVVXZLR4J3U4JUX3O3T5ZFLVANCNFSM5CE57WXQ>. > Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
