BLasan commented on a change in pull request #1770:
URL: https://github.com/apache/fineract/pull/1770#discussion_r698034846
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanApplicationWritePlatformServiceJpaRepositoryImpl.java
##########
@@ -991,10 +1101,19 @@ public CommandProcessingResult modifyApplication(final
Long loanId, final JsonCo
existingLoanApplication.updateTransactionProcessingStrategy(strategy);
}
- final String collateralParamName = "collateral";
- if (changes.containsKey(collateralParamName)) {
- final Set<LoanCollateral> loanCollateral =
this.loanCollateralAssembler.fromParsedJson(command.parsedJson());
- existingLoanApplication.updateLoanCollateral(loanCollateral);
+ /**
+ * TODO: Allow other loan types.
+ */
Review comment:
Nope. This can be considered as a future work. In this context we'll
allow this for the individual loan type only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
