BLasan commented on a change in pull request #1770:
URL: https://github.com/apache/fineract/pull/1770#discussion_r701823116
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
##########
@@ -3008,6 +3021,14 @@ public void makeRefund(final LoanTransaction
loanTransaction, final LoanLifecycl
final String errorMessage = "Transfer funds is allowed only for
loan accounts with overpaid status ";
throw new InvalidLoanStateTransitionException("transaction",
"is.not.a.overpaid.loan", errorMessage);
}
+
+ // // Update the transaction in loan collateral module.
Review comment:
Fixed
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainService.java
##########
@@ -48,6 +49,12 @@ LoanTransaction makeDisburseTransaction(Long loanId,
LocalDate transactionDate,
LoanTransaction makeRefundForActiveLoan(Long accountId,
CommandProcessingResultBuilder builderResult, LocalDate transactionDate,
BigDecimal transactionAmount, PaymentDetail paymentDetail, String
noteText, String txnExternalId);
+ void updateLoanCollateralTransaction(Set<LoanCollateralManagement>
loanCollateralManagementList);
+
+ // BigDecimal getTotalQuantity(Loan loan);
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
