IOhacker commented on pull request #1882: URL: https://github.com/apache/fineract/pull/1882#issuecomment-925825086
Hi Awasum, I will fix it adding the update script. Also I have noticed an error while running the integraron test in the Pentaho reports. Regards El jue., 23 de septiembre de 2021 3:59 a. m., Awasum Yannick < ***@***.***> escribió: > ***@***.**** requested changes on this pull request. > ------------------------------ > > In > fineract-provider/src/main/resources/sql/migrations/core_db/V119__add_template_table.sql > <https://github.com/apache/fineract/pull/1882#discussion_r714601554>: > > > @@ -31,9 +31,9 @@ CREATE TABLE `m_template` ( > DROP TABLE IF EXISTS `m_templatemappers`; > CREATE TABLE `m_templatemappers` ( > `id` BIGINT NOT NULL AUTO_INCREMENT, > - `mapperkey` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > + `mapperkey` varchar(255) COLLATE utf8mb4_general_ci DEFAULT NULL, > > What happens to old deployments when u update and previous migration file? > Can we instead update in a newer migration script? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/fineract/pull/1882#pullrequestreview-761757046>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALD2ZAQI4ZYHSZ4PKQUI7JDUDLUADANCNFSM5ESZ5F5Q> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
