jamesidw opened a new pull request #1888: URL: https://github.com/apache/fineract/pull/1888
## Description The previous/current approach to removing duplicates from the `LoanProductProvisioningEntry` collection generated is to check for equality between two objects and add the reserved amount of one to the other if they are the same. This doesn't take into account the possibility that the new total amount may make the object similar to another object in the collection. The change I'm proposing is to group the similar entries before considering the reserved amount. So if the only difference between two entries is the reserve amount, we should sum up their values. Any other entries that remain will have at least some other field that is different and shouldn't cause duplicates. See details in [FINERACT-1404](https://issues.apache.org/jira/browse/FINERACT-1404). ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update unit or integration tests for verifying the changes made. - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions. - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.) FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
