ptuomola commented on a change in pull request #1883:
URL: https://github.com/apache/fineract/pull/1883#discussion_r725415363
##########
File path: build.gradle
##########
@@ -115,7 +115,7 @@ allprojects {
dependency
'com.google.truth.extensions:truth-java8-extension:1.1.3'
dependency 'org.apache.commons:commons-email:1.5'
dependency 'commons-io:commons-io:2.11.0'
- dependency 'org.drizzle.jdbc:drizzle-jdbc:1.4'
+ dependency 'org.mariadb.jdbc:mariadb-java-client:2.7.3'
dependency 'com.github.librepdf:openpdf:1.3.26'
Review comment:
Given that we can't bundle a LGPL driver, we need to find some way to a)
use it as a dependency in the classpath but b) not bundle it in the release
JAR. I'd suggest experimenting with the different gradle classpaths to do this
(e.g. is it adding this to runtimeClasspath rather than
implementationClasspath?)
##########
File path: LICENSE_RELEASE
##########
@@ -243,9 +243,9 @@ This product bundles DOM4J, Copyright 2001-2005 (C)
MetaStuff, Ltd.,
which is available under a BSD license.
For details, see licenses/binary/Dom4J.BSD
-This product bundles JDBC driver for MySQL and Drizzle v1.3, Copyright (c)
-2009-2013, Marcus Eriksson which is available under a BSD license.
-For details, see licenses/binary/Drizzle.BSD
+This product bundles JDBC driver for MariaDB v2.7.3, Copyright (c)
+which is available under a LGPL license.
+For details, see https://mariadb.com/kb/en/about-mariadb-connector-j/#license
Review comment:
If my understanding is correct, I don't think we are allowed to bundle
anything with a LGPL license. We can make the JDBC driver a dependency so that
is is downloaded at build / run time - that way the users can choose to use
another, non-LGPL'd, JDBC driver. But we should not bundle anything in our
release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
