avikganguly01 commented on a change in pull request #1886:
URL: https://github.com/apache/fineract/pull/1886#discussion_r725999368



##########
File path: fineract-provider/properties/basicauth/application.properties
##########
@@ -30,3 +30,6 @@ management.info.git.mode=FULL
 
 # FINERACT-914
 server.forward-headers-strategy=framework
+
+# FINERACT-429
+node.id=1

Review comment:
       Can we set node.id in environment variables like we are doing for other 
environment variables? 
https://github.com/apache/fineract/blob/develop/docker-compose.yml
   We might or might not be using basicauth or oauth application.properties so 
this is probably not the right place.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to