avikganguly01 commented on a change in pull request #1702:
URL: https://github.com/apache/fineract/pull/1702#discussion_r726004867
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
##########
@@ -1622,6 +1627,13 @@ public void updateLoanSummarAndStatus() {
this.fixedEmiAmount = null;
}
+ if
(command.isChangeInBigDecimalParameterNamed(LoanApiConstants.fixedPrincipalPercentagePerInstallmentParamName,
+ this.fixedPrincipalPercentagePerInstallment)) {
+ this.fixedPrincipalPercentagePerInstallment = command
+
.bigDecimalValueOfParameterNamed(LoanApiConstants.fixedPrincipalPercentagePerInstallmentParamName);
+
actualChanges.put(LoanApiConstants.fixedPrincipalPercentagePerInstallmentParamName,
this.fixedEmiAmount);
+ }
Review comment:
@fynmanoj : Can you confirm this and rebase it again? Rest of it looks
good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
