BLasan commented on a change in pull request #1884:
URL: https://github.com/apache/fineract/pull/1884#discussion_r727524784
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java
##########
@@ -1021,7 +1021,7 @@ public static LoanAccountData
loanProductWithTemplateDefaults(final LoanProductD
final Collection<CalendarData> calendarOptions = null;
final Collection<StaffData> loanOfficerOptions = null;
- final EnumOptionData termPeriodFrequencyType =
product.getRepaymentFrequencyType();
Review comment:
Any reassignments?
##########
File path:
integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanDisbursementDetailsIntegrationTest.java
##########
@@ -211,23 +211,24 @@ private void
validateRepaymentScheduleWithEMI(ArrayList<HashMap> periods) {
private void assertRepaymentScheduleValuesWithEMI(HashMap period,
LoanDisbursementTestBuilder expectedRepaymentSchedule, int position) {
assertEquals(period.get("dueDate").toString(),
expectedRepaymentSchedule.getDueDate());
- assertEquals(period.get("principalLoanBalanceOutstanding"),
expectedRepaymentSchedule.getPrincipalLoanBalanceOutstanding());
+
assertEquals(Float.parseFloat(period.get("principalLoanBalanceOutstanding").toString()),
Review comment:
Why converted to a Float comparison?
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/data/LoanProductData.java
##########
@@ -624,7 +625,8 @@ public LoanProductData(final Long id, final String name,
final String shortName,
boolean isFloatingInterestRateCalculationAllowed, final boolean
isVariableInstallmentsAllowed,
final Integer minimumGapBetweenInstallments, final Integer
maximumGapBetweenInstallments,
final boolean syncExpectedWithDisbursementDate, final boolean
canUseForTopup, final boolean isEqualAmortization,
- Collection<RateData> rateOptions, Collection<RateData> rates,
final boolean isRatesEnabled) {
+ Collection<RateData> rateOptions, Collection<RateData> rates,
final boolean isRatesEnabled, final LocalDate firstDateForSemi,
Review comment:
Why `rateOptions` and `rates` are not final? Any reassignment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
