avikganguly01 commented on a change in pull request #1935:
URL: https://github.com/apache/fineract/pull/1935#discussion_r737356282
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/accounting/common/AccountingDropdownReadPlatformServiceImpl.java
##########
@@ -36,7 +36,7 @@
private final GLAccountReadPlatformService accountReadPlatformService;
@Autowired
- public AccountingDropdownReadPlatformServiceImpl(final
GLAccountReadPlatformService accountReadPlatformService) {
+ public
AccountingDropdownReadPlatformServiceImpl(GLAccountReadPlatformService
accountReadPlatformService) {
Review comment:
Assign final.
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountChargeReadPlatformServiceImpl.java
##########
@@ -185,6 +191,23 @@ public SavingsAccountChargeData
retrieveSavingsAccountChargeDetails(final Long i
}
}
+ @Override
+ public long retrieveSavingsAccountChargeDetailsId(final Long id, final
Long savingsAccountId) {
Review comment:
This function is not called anywhere. Please remove unused code when
sending the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
