rrpawar96 commented on a change in pull request #1969:
URL: https://github.com/apache/fineract/pull/1969#discussion_r748731070
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java
##########
@@ -1076,16 +1076,19 @@ private void payWithdrawalFee(final BigDecimal
transactionAmount, final LocalDat
for (SavingsAccountCharge charge : this.charges()) {
if (charge.isWithdrawalFee() && charge.isActive()) {
- if (charge.getFreeWithdrawalCount() == null) {
- charge.setFreeWithdrawalCount(0);
- }
- if (charge.isEnableFreeWithdrawal()) {
- resetFreeChargeDaysCount(charge, transactionAmount,
transactionDate, user);
+ if
(paymentDetail.getPaymentType().getPaymentName().equals(charge.getCharge().getPaymentType().getPaymentName()))
{
Review comment:
condition 1: if the charge has both condition of specific paymentType
and discountType (FINERACT-1374)
condition 2 : charge is assigned to specific payment type but normal
charge(no discount Type)
condition 3: discount charge but no condition of paymentType.
condition 4 : normal withdraw charges
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
