ptuomola opened a new pull request #1990:
URL: https://github.com/apache/fineract/pull/1990


   ## Description
   
   Building on (and including) the excellent work of @IOhacker, this completes 
the removal of Drizzle from all parts of the code. This also stops including 
any JDBC driver in the built jars / wars and instead instructs the user to 
include their favourite JDBC driver in the classpath when running the JAR / 
WAR. 
   
   The built docker image still continues to include the MariaDB driver JAR but 
instructions are provided to replace it with another if the user so prefers. 
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [ ] Write the commit message as per 
https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at 
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details 
of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in 
repository" via a branch.  Ask on the developer mailing list for guidance, if 
required.)
   
   FYI our guidelines for code reviews are at 
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to