rrpawar96 commented on a change in pull request #2002:
URL: https://github.com/apache/fineract/pull/2002#discussion_r775236113
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepository.java
##########
@@ -67,10 +67,12 @@
String DOES_PRODUCT_HAVE_NON_CLOSED_LOANS = "select case when (count
(loan) > 0) then 'true' else 'false' end from Loan loan where
loan.loanProduct.id = :productId and loan.loanStatus in
(100,200,300,303,304,700)";
- String FIND_BY_ACCOUNT_NUMBER = "select loan from Loan loan where
loan.accountNumber = :accountNumber and loan.loanStatus in
(100,200,300,303,304)";
+ String FIND_NON_CLOSED_BY_ACCOUNT_NUMBER = "select loan from Loan loan
where loan.accountNumber = :accountNumber and loan.loanStatus in
(100,200,300,303,304)";
Review comment:
Yes, we are not using FIND_NON_CLOSED_BY_ACCOUNT_NUMBER, I have just
changed the variableName here to avoid confusion, We are using a new SQL
statement that I have created, FIND_BY_ACCOUNT_NUMBER which takes all accounts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
