ptuomola commented on a change in pull request #2013:
URL: https://github.com/apache/fineract/pull/2013#discussion_r777464762
##########
File path:
integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanDisbursementDetailsIntegrationTest.java
##########
@@ -76,7 +76,7 @@ public void createAndValidateMultiDisburseLoansBasedOnEmi() {
String withoutInstallmentAmount = "";
String proposedAmount = "10000";
createTranches.add(this.loanTransactionHelper.createTrancheDetail(id,
"01 June 2015", "5000"));
- createTranches.add(this.loanTransactionHelper.createTrancheDetail(id,
"01 Sep 2015", "5000"));
+ createTranches.add(this.loanTransactionHelper.createTrancheDetail(id,
"01 September 2015", "5000"));
Review comment:
Ok - looks like this has indeed changed for JDK17:
https://stackoverflow.com/questions/69267710/septembers-short-form-sep-no-longer-parses-in-java-17-in-en-gb-locale
It's not nice that this would potentially break some clients. But I suppose
this should never happen as long as people are using machine generated dates -
as they should be providing the correct string anyway. It's only if someone is
manually typing "17 Sep" or hardcoding such strings.
But I don't think it warrants implementing some specific handling in
Fineract, given that this will be the standard for all solutions compiled with
JDK17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
