galovics commented on pull request #2029: URL: https://github.com/apache/fineract/pull/2029#issuecomment-1032397557
@ptuomola Thanks for taking the time and giving feedback. I appreciate. Your point is probably valid and in some corner cases this doesn't work and I'm not sure if this is going to work in all environments. The reason why on Windows this didn't work is because the file URI schema is not followed. The `file://` prefix is missing an extra slash since it's pointing to a local file. According to the RFC, this is not a valid URI scheme for files but some systems accept it. [RFC here](https://datatracker.ietf.org/doc/html/rfc8089#appendix-B) To make sure this still works the way it should, instead of removing the file URI prefix, I added the extra missing slash to make sure it's compliant with the RFC and that's something Windows also accepts. The end result is `file:///` See the updated PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
