taskain7 commented on a change in pull request #2144:
URL: https://github.com/apache/fineract/pull/2144#discussion_r824900840
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanApplicationTerms.java
##########
@@ -1773,7 +1773,7 @@ private void
updateRecurringMoratoriumOnPrincipalPeriods(Integer periodNumber) {
}
- public void setTotalPrincipalAccounted(Money totalPrincipalAccounted) {
+ public void setTotalPrincipalAccountedForInterestCalculation(Money
totalPrincipalAccounted) {
Review comment:
There is also a `totalPrincipalAccounted` field in this object, so the
original name of the setter is misleading, and does not do what says.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]