vidakovic commented on a change in pull request #2137:
URL: https://github.com/apache/fineract/pull/2137#discussion_r824946300
##########
File path:
fineract-provider/src/test/java/org/apache/fineract/accounting/common/AccountingFinanciaActivityScenario.java
##########
@@ -18,14 +18,25 @@
*/
package org.apache.fineract.accounting.common;
-import org.junit.jupiter.api.Test;
-import org.springframework.util.Assert;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
-public class AccountingConstantsTest {
+import io.cucumber.java8.En;
+import java.util.List;
+import
org.apache.fineract.accounting.financialactivityaccount.data.FinancialActivityData;
- @Test
- public void testGetAllFinancialActivities() {
-
Assert.notEmpty(AccountingConstants.FinancialActivity.getAllFinancialActivities(),
- "static initialization of collection of all enums is broken");
+public class AccountingFinanciaActivityScenario implements En {
+
+ private List<FinancialActivityData> data;
+
+ public AccountingFinanciaActivityScenario() {
+ Given("All financial activities", () -> {
+ this.data =
AccountingConstants.FinancialActivity.getAllFinancialActivities();
+ });
+
+ Then("The they should not be empty", () -> {
+ assertNotNull(data);
+ assertFalse(data.isEmpty());
Review comment:
Alright... then we'll settle on this... we should use the same asserts
everywhere then. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
