galovics edited a comment on pull request #2176:
URL: https://github.com/apache/fineract/pull/2176#issuecomment-1083318807


   @sheminanto let's differentiate 2 things, the migration and the report 
execution. The migration is going to run successfully for sure since you're 
inserting some SQL strings into the report table. But when you try to execute 
the SQL statements you inserted into the report table - i.e. querying a report, 
it's going to fail.
   For example the backtick (\`) is a specific character only used for MySQL to 
escape literals. That's going to fail with PostgreSQL. You can look at the 
existing migrations in `0001_initial_data.xml`. There's a separate changeset 
for MySQL and PostgreSQL.
   Also, since this didn't fail the build, I'd appreacite if you could add some 
integration tests for each report you created.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to