John-Woodlock commented on code in PR #2278:
URL: https://github.com/apache/fineract/pull/2278#discussion_r850484423
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java:
##########
@@ -623,6 +623,41 @@ private AppUser getAppUserIfPresent() {
return user;
}
+ @Override
+ public CommandProcessingResultBuilder creditBalanceRefund(Long loanId,
LocalDate transactionDate, BigDecimal transactionAmount,
Review Comment:
Thanks Arnold,
I have updated the Lombok related changes.
I accept the need to reduce/refactor Java code. I'll like an amnesty on
this issue because, as said in the notes, it is a new loan transaction (very
rare) so there will be some extra (but not major) additional code to loan.java
- but I think I can do a better job of reducing the code soon as I'm looking at
the core loan area and expect it would be more natural there to
reduce/refactor... so in short, I'm fully onboard the care for the code drive
but will be more productive soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
