galovics commented on PR #2286: URL: https://github.com/apache/fineract/pull/2286#issuecomment-1104876840
I'd like to reiterate my comment from the other PR: https://github.com/apache/fineract/pull/2285 The GCP related things shouldn't pollute the configurations everywhere but it should be extracted out (similarly what I suggested on the other PR). Also, the property name `fineract.security.on.gcp` is definitely not going to fly with me because it doesn't represent the hierarchical naming. Probably for cloud native environments, it would make sense to start with the `fineract.gcp` group and then name this particular property `fineract.gcp.security.enabled`. This way we can capture all GCP related properties in a single group while keeping it very easy to extend. What do you think Victor? cc @vidakovic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
