ptuomola commented on code in PR #2289:
URL: https://github.com/apache/fineract/pull/2289#discussion_r855859697
##########
.github/workflows/sonarqube.yml:
##########
@@ -9,11 +9,11 @@ jobs:
runs-on: ubuntu-20.04
env:
TZ: Asia/Kolkata
- SONAR_ORGANIZATION: ${{ secrets.SONAR_ORGANIZATION }}
- SONAR_PROJECT_KEY: ${{ secrets.SONAR_PROJECT_KEY }}
- SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
- SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+ SONAR_ORGANIZATION: apache
Review Comment:
Except it might now be even easier at it seems they've added secrets support
to the gh cli: https://github.com/cli/cli/releases/tag/v1.4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
