galovics commented on code in PR #2295:
URL: https://github.com/apache/fineract/pull/2295#discussion_r858381611
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataServiceImpl.java:
##########
@@ -226,38 +216,16 @@ public List<ResultsetColumnHeaderData>
fillResultsetColumnHeaders(final String d
List<ResultsetColumnValueData> columnValues = new ArrayList<>();
String codeName = null;
- if ("varchar".equalsIgnoreCase(columnType)) {
-
- final int codePosition = columnName.indexOf("_cv");
+ final int codePosition = columnName.indexOf("_cd");
+ if ("varchar".equalsIgnoreCase(columnType) ||
"int".equalsIgnoreCase(columnType) || "integer".equalsIgnoreCase(columnType)) {
if (codePosition > 0) {
codeName = columnName.substring(0, codePosition);
-
columnValues = retreiveColumnValues(codeName);
}
-
Review Comment:
Could you please elaborate on these changes? I'm having a hard time
understanding them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
