vidakovic commented on PR #2298: URL: https://github.com/apache/fineract/pull/2298#issuecomment-1110664758
To stay with your argument: you could say the same of the docker compose file in the root folder. That said: I am not too religious about where to put it. But even as documentation people will copy and paste and you'll end up in the same place. And: if they have nothing in place they end up with the default the default values anyway... which are exactly the same as in this setenv.sh. Something though needs to be done, because there are more WAR users out there that don't know how to translate the Docker env vars for their deployments. I would leave it in place, add it to documentation and emphasize that this is an example config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
