vidakovic commented on code in PR #2309:
URL: https://github.com/apache/fineract/pull/2309#discussion_r863695559
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java:
##########
@@ -110,12 +111,14 @@ private boolean is(final String commandParam, final
String commandValue) {
@Produces({ MediaType.APPLICATION_JSON })
@Operation(summary = "Retrieve Loan Transaction Template", description =
"This is a convenience resource. It can be useful when building maintenance
user interface screens for client applications. The template data returned
consists of any or all of:\n"
+ "\n" + "Field Defaults\n" + "Allowed Value Lists\n\n" + "Example
Requests:\n" + "\n"
- + "loans/1/transactions/template?command=repayment" + "\n" +
"loans/1/transactions/template?command=waiveinterest" + "\n"
- + "loans/1/transactions/template?command=writeoff" + "\n" +
"loans/1/transactions/template?command=close-rescheduled" + "\n"
- + "loans/1/transactions/template?command=close" + "\n" +
"loans/1/transactions/template?command=disburse" + "\n"
- + "loans/1/transactions/template?command=disburseToSavings" + "\n"
+ "loans/1/transactions/template?command=recoverypayment"
- + "\n" + "loans/1/transactions/template?command=prepayLoan" + "\n"
+ "loans/1/transactions/template?command=refundbycash" + "\n"
- + "loans/1/transactions/template?command=refundbytransfer" + "\n"
+ "loans/1/transactions/template?command=foreclosure" + "\n"
+ + "loans/1/transactions/template?command=repayment" +
"loans/1/transactions/template?command=merchantIssuedRefund"
Review Comment:
Any reason why we have these unnecessary concatenations in the middle of the
line? I see the utility splitting up the string at the end of the line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
