logoutdhaval commented on code in PR #2310:
URL: https://github.com/apache/fineract/pull/2310#discussion_r864035349
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/GenericResultsetData.java:
##########
@@ -27,10 +27,15 @@ public final class GenericResultsetData {
private final List<ResultsetColumnHeaderData> columnHeaders;
private final List<ResultsetRowData> data;
+ private Integer totalItems;
Review Comment:
changed to primitive
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadReportingServiceImpl.java:
##########
@@ -69,14 +79,23 @@ public class ReadReportingServiceImpl implements
ReadReportingService {
private final PlatformSecurityContext context;
private final GenericDataService genericDataService;
private final SqlInjectionPreventerService sqlInjectionPreventerService;
+ private final DatabaseSpecificSQLGenerator sqlGenerator;
+ private final ConfigurationDomainService configurationDomainService;
+ private final PaginationHelper paginationHelper;
+ private static final String ORDER_BY_REGEX_PATTERN = "^[0-9]*$";
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
