logoutdhaval commented on code in PR #2310:
URL: https://github.com/apache/fineract/pull/2310#discussion_r865778436
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadReportingServiceImpl.java:
##########
@@ -61,23 +71,19 @@
import org.springframework.stereotype.Service;
@Service
+@AllArgsConstructor(onConstructor = @__(@Autowired))
public class ReadReportingServiceImpl implements ReadReportingService {
+ private static final String ORDER_BY_REGEX_PATTERN = "^[0-9]*$";
Review Comment:
Since, Stretchy report is a generic functionality and can serve multiple
reports in a generic way, knowing the actual column name for each report will
be very difficult.
Even if the column order changes user can select the correct index and run
the report to receive the report as per the requirement.
Column idx method is adopted to keep it generic and to work with the current
framework with minimal invasive changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
