fynmanoj commented on code in PR #2353:
URL: https://github.com/apache/fineract/pull/2353#discussion_r893661257


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java:
##########
@@ -980,7 +980,7 @@ protected void recalculateDailyBalances(final Money 
openingAccountBalance, final
             } else {
                 Money overdraftAmount = Money.zero(this.currency);
                 Money transactionAmount = Money.zero(this.currency);
-                if (transaction.isCredit() || transaction.isAmountRelease()) {
+                if ((transaction.isCredit() || transaction.isAmountRelease()) 
&& !transaction.isReversalTransaction()) {

Review Comment:
   add this condition to the if condition above, no need to add it here  `if 
(transaction.isReversed() || transaction.isReversalTransaction()) {
                   transaction.zeroBalanceFields(); 
   }`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to