fynmanoj commented on code in PR #2379:
URL: https://github.com/apache/fineract/pull/2379#discussion_r906011721
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountInterestPostingServiceImpl.java:
##########
@@ -449,7 +449,9 @@ protected void recalculateDailyBalances(final Money
openingAccountBalance, final
}
runningBalance = runningBalance.plus(transactionAmount);
- transaction.updateRunningBalance(runningBalance);
+ if
(!transaction.getRunningBalance(transactionAmount.getCurrency()).isEqualTo(transactionAmount))
{
Review Comment:
how can we compare transaction amount with running balance? what is the
logic here?
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionData.java:
##########
@@ -155,7 +155,7 @@ public boolean isDebit() {
}
public boolean isWithdrawalFeeAndNotReversed() {
- return this.transactionType.isWithdrawalFee() && isNotReversed();
+ return this.transactionType.isFeeDeduction() && isNotReversed();
Review Comment:
is reversal case already handled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
