adamsaghy commented on code in PR #2369: URL: https://github.com/apache/fineract/pull/2369#discussion_r909021575
########## integration-tests/src/test/java/org/apache/fineract/integrationtests/accounting/AccountingRuleIntegrationTest.java: ########## @@ -0,0 +1,79 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.integrationtests.accounting; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; + +import io.restassured.builder.RequestSpecBuilder; +import io.restassured.builder.ResponseSpecBuilder; +import io.restassured.http.ContentType; +import io.restassured.specification.RequestSpecification; +import io.restassured.specification.ResponseSpecification; +import java.util.ArrayList; +import org.apache.fineract.client.models.GetAccountRulesResponse; +import org.apache.fineract.client.models.GetOfficesResponse; +import org.apache.fineract.client.models.PostAccountingRulesResponse; +import org.apache.fineract.integrationtests.common.OfficeHelper; +import org.apache.fineract.integrationtests.common.Utils; +import org.apache.fineract.integrationtests.common.accounting.Account; +import org.apache.fineract.integrationtests.common.accounting.AccountHelper; +import org.apache.fineract.integrationtests.common.accounting.AccountRuleHelper; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +public class AccountingRuleIntegrationTest { + + private ResponseSpecification responseSpec; + private RequestSpecification requestSpec; + + private AccountHelper accountHelper; + private AccountRuleHelper accountRuleHelper; + + @BeforeEach + public void setup() { + Utils.initializeRESTAssured(); + + requestSpec = new RequestSpecBuilder().setContentType(ContentType.JSON).build(); + requestSpec.header("Authorization", "Basic " + Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey()); + responseSpec = new ResponseSpecBuilder().expectStatusCode(200).build(); + + accountRuleHelper = new AccountRuleHelper(requestSpec, responseSpec); + accountHelper = new AccountHelper(requestSpec, responseSpec); + } + + @Test + public void testAccountingRuleCreation() { + // given + final Account accountToCredit = accountHelper.createIncomeAccount(); + final Account accountToDebit = accountHelper.createExpenseAccount(); + final GetOfficesResponse headOffice = OfficeHelper.getHeadOffice(requestSpec, responseSpec); + + // when + final PostAccountingRulesResponse accountingRule = accountRuleHelper.createAccountRule(headOffice.getId(), accountToCredit, + accountToDebit); + assertNotNull(accountingRule); + assertNotNull(accountingRule.getResourceId()); + + // then + final ArrayList<GetAccountRulesResponse> accountingRules = accountRuleHelper.getAccountingRules(); + assertNotNull(accountingRules); + assertEquals(1, accountingRules.size()); Review Comment: I understand there is no any integration tests for accounting rules...yet. 1. But what if i created one tomorrow and as the execution order of the tests are not specified it could happen that the new test is executed earlier and if that integration test is creating an accounting rule, your test will fail. 2. You are not testing whether the accounting rule were created properly as there are missing checks for: - officeId - accountCreditId - accountDebitId - name - description My recommendation is to avoid checks like: - assertEquals(1, accountingRules.size()); And preferrably find the created accounting rule (from the list or retrieve it by ID) entry and check its details one by one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
