galovics commented on code in PR #2402:
URL: https://github.com/apache/fineract/pull/2402#discussion_r912826685
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java:
##########
@@ -168,4 +168,14 @@ public String currentSchema() {
throw new IllegalStateException("Database type is not supported
for current schema " + databaseTypeResolver.databaseType());
}
}
+
+ public String getBoolean(boolean condition) {
+ if (databaseTypeResolver.isMySQL()) {
Review Comment:
> it is not "worse" pattern like providing a boolean to the tinyInt
I don't agree with that. If the database engine provides the true/false
literals and it'll translate them into 1/0 values, that's much better if you're
really representing boolean values instead of using the numbers themselves.
It's just semantically better.
Same for the booleans in Java. The underlying JVM represents them as 0/1
bits and I bet you don't want to use numbers there too. ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
