adamsaghy opened a new pull request, #2406:
URL: https://github.com/apache/fineract/pull/2406
## Description
While the AppUser (entity) was the auditor, the Spring JPA Auditing was not
working perfectly. When a detached entity was saved through assosication the
AppUser auditor was not set and it was null in the DB.
Example:
- Find Loan by id
- Create a new transaction
- Add the loan transaction to the Loan
- Save the Loan entity
Outcome:
- Loan transaction created by id was null
Solution
The AppUser entity was changed to be just the AppUser id. It is working just
fine now, and anyway the AppUser was never used and was unnecessary anyway to
be fetched.
Similar issue:
https://stackoverflow.com/questions/38828189/spring-data-jpa-auditing-fails-when-persisting-detached-entity
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per
https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in
repository" via a branch. Ask on the developer mailing list for guidance, if
required.)
FYI our guidelines for code reviews are at
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
