galovics commented on code in PR #2428:
URL: https://github.com/apache/fineract/pull/2428#discussion_r921916968
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientChargeReadPlatformServiceImpl.java:
##########
@@ -151,7 +151,7 @@ public Page<ClientChargeData> retrieveClientCharges(Long
clientId, String status
// filter for paid charges
if (pendingPayment != null && pendingPayment) {
Review Comment:
I know you haven't implemented this but since you touched the other
condition, can we maybe switch this to BooleanUtils.isTrue and respectively
BooleanUtils.isFalse?
Much easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
