galovics commented on code in PR #2454:
URL: https://github.com/apache/fineract/pull/2454#discussion_r932068612
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/ConfigurationDomainServiceJpa.java:
##########
@@ -444,4 +444,11 @@ public boolean isBusinessDateEnabled() {
public boolean isCOBDateAdjustmentEnabled() {
return
getGlobalConfigurationPropertyData(ENABLE_AUTOMATIC_COB_DATE_ADJUSTMENT).isEnabled();
}
+
+ @Override
+ public boolean isReversalTransactionAllowed() {
+ final String propertyName =
"allow-reversals-for-reversed-transactions";
Review Comment:
This configuration is misleadingly named. As far as I can see, you touched
FixedDepositAccounts, RecurringDepositAccount and SavingsAccounts.
Please name the config accordingly cause judging by its name it should also
configure all other type of accounts, for example Loan accounts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
