vidakovic commented on code in PR #2481:
URL: https://github.com/apache/fineract/pull/2481#discussion_r940036345
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/config/FineractProperties.java:
##########
@@ -36,6 +37,8 @@ public class FineractProperties {
private FineractCorrelationProperties correlation;
+ private FineractPartitionedJobProperties fineractPartitionedJobProperties;
Review Comment:
I think the "fineract" prefix is not necessary here; this nested class is
already in FineractProperties... so kind of redundant. Same for the suffix
"Properties"; that kind of is self-evident.
I'd suggest to name this attribute just `partionedJob` if you insist using
the class `FineractPartitionedJobProperties`; but as this class only contains 1
attribute I'd just move `List<JobProperty> jobProperties` here and name the
variable `partitionedJobProperties`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
